Re: [Xen-devel] [PATCH v5 05/16] x86/hvm: unify internal portio and mmio intercepts

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Roger Pau Monné [mailto:roger.pau@xxxxxxxxxx]
> Sent: 02 July 2015 15:52
> To: Paul Durrant; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Andrew Cooper; Keir (Xen.org); Jan Beulich
> Subject: Re: [Xen-devel] [PATCH v5 05/16] x86/hvm: unify internal portio and
> mmio intercepts
> 
> El 30/06/15 a les 15.05, Paul Durrant ha escrit:
> [...]
> +void msixtbl_init(struct domain *d)
> > +{
> > +    register_mmio_handler(d, &msixtbl_mmio_ops);
> 
> Since you are adding an initialization function to vmsi I think
> msixtbl_list and msixtbl_list_lock should also be initialized here
> instead of hvm_domain_initialise.
> 

Yes, that sounds quite reasonable. Perhaps as a follow-up patch though, unless 
I need to post v6 of the series for some other reason.

  Paul

> Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel