Re: [Xen-devel] [PATCH v5 10/16] x86/hvm: only call hvm_io_assist() from hvm_wait_for_io()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 30/06/15 14:05, Paul Durrant wrote:
> diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c
> index 11b6028..f84f7c5 100644
> --- a/xen/arch/x86/hvm/intercept.c
> +++ b/xen/arch/x86/hvm/intercept.c
> @@ -119,8 +119,8 @@ static const struct hvm_io_ops portio_ops = {
>      .write = hvm_portio_write
>  };
>  
> -static int hvm_process_io_intercept(const struct hvm_io_handler *handler,
> -                                    ioreq_t *p)
> +int hvm_process_io_intercept(const struct hvm_io_handler *handler,
> +                             ioreq_t *p)

Again, I would suggest introducing this as a global function straight
away, to reduce the eventual churn.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel