[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/7] libxc: fix uninitialized variable in xc_cpuid_pv_policy()

Ian Campbell writes ("Re: [Xen-devel] [PATCH 1/7] libxc: fix uninitialized 
variable in xc_cpuid_pv_policy()"):
> On Fri, 2015-07-03 at 16:15 +0100, Ian Jackson wrote:
> > Unfortunately xc_cpuid_pv_policy doesn't return an error code.  I
> > think it needs to.  So that's rather a yak.
> I was about to say it's not one worth shaving, but actually although
> this returns void it is static and has exactly one caller which can
> return errors -- so it's a very easy yakk to shave it seems.

I guess part of my view is that the point of having Coverity spot
anomalies is to find broken code and fix it.

To then look at the issues which we spot as a result of looking at the
code, when prodded by Coverity, and decide to fix only half of the
problem, is to waste the opportunity for improvement presented by
Coverity.  (Or to look at it another way it is a waste of the effort
of setting up Coverity and then wading through the false positives.)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.