[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 05/32] libxc: make arch_setup_meminit a xc_dom_arch hook

On 03/07/15 12:34, Roger Pau Monne wrote:
> This allows having different arch_setup_meminit implementations based on the
> guest type. It should not introduce any functional changes.
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

However, would you mind doing a cleanup patch which changes the use of
__init.  Confusingly given its precedent in hypervisor code, xc_dom.h
has "#define __init __attribute__ ((constructor))".  At a first guess,
'initcall' or even just 'constructor' would be more appropriate names.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.