[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Tue, 7 Jul 2015 09:26:23 +0300
  • Cc: keir@xxxxxxx, Ian Campbell <ian.campbell@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>, stefano.stabellini@xxxxxxxxxx, Tamas Lengyel <tlengyel@xxxxxxxxxxx>
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Tue, 07 Jul 2015 06:26:36 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=qqrLdBsEKgDfBtJ6XHSmFe+3TPR7OlpQEAbo/KjZec6zzOL9zvOLcOCY51A5eBWc4QoQRnmOrd3gabLId1s3s2TtVlKrX8hQbdB8DO5d4U+HybZMPpk9qvdgs23nTp/R057CF88Lm8uOhPgjN641PYvg/Kj/JRtEsGl7dI9+VEYzAkh4A8bvVZzl1MPjUs6bpYQD9PdjCGWzsm5LRLiSBxNeq9gotAv68EZuEpz6nkdLJ9MgcyOQLWIPG9IWDLSMwRN2PNZg7cq58kgDK/UWX5fSXB53HWxGLMrdMn7xtJL6vGIBQg6VK1l4cYFUXzlwUlXv+IKJO2xCIV68KHLAXw==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 07/07/2015 09:20 AM, Jan Beulich wrote:
>>>> On 06.07.15 at 19:03, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>> I don't mind just having the comment for now, so for what it's worth I
>> stand by my ack.
>> Having said that (and with the understading that it is beyond the scope
>> of this patch), a way to validate things like these is a good idea. I
>> wonder if, in a future patch, we could not have ./configure detect these
>> things and simply disable the relevant VM_EVENT_FLAG constants with
>> #if(n)defs, for example. That way, you wouldn't be able to compile code
>> that wouldn't work silently on platforms where that is the case.
> I don't follow: Are you saying this assuming that everyone would
> configure and build on the target system? I.e. are you leaving
> distros completely out of consideration?

I was, as also pointed out by Andrew. Tamas has, in the meantime,
submitted a patch doing this the right way (adding the ability to query
hypervisor capabilities).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.