[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3 2/3] xen/vm_event: Support for guest-requested events

On 07/07/2015 09:30 AM, Jan Beulich wrote:
On 06.07.15 at 17:51, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
@@ -6388,6 +6387,13 @@ long do_hvm_op(unsigned long op, 

+    case HVMOP_guest_request_vm_event:
+        if ( guest_handle_is_null(arg) )
+            hvm_event_guest_request();
+        else
+            rc = -EINVAL;
+        break;

Pending Daniel's confirmation that not having an XSM check here
is okay,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

I don't think an XSM check is needed here, if only because the events are
being added to an existing channel from the guest to the monitor.  The
best way to control this communication is probably when the shared page is
mapped by the monitor, but this is an existing mechanism which appears to
be covered by the ability to map any page in the target domain.

Daniel De Graaf
National Security Agency

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.