[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 for Xen 4.6 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler

So, about the structure of the patch/changelog/etc, taking this patch as
an example.

On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
> Add two hypercalls(XEN_DOMCTL_SCHEDOP_getvcpuinfo/putvcpuinfo) to get/set a 
> domain's
> per-VCPU parameters.
This is almost ok. Line should be shorter (try a `git log' with this
patch committed, and check how it looks).

Also, I'd rephrase it as "Add XEN_DOMCTL_SCHEDOP_getvcpuinfo and
_putvcpuinfo hypercalls to independently get and set the scheduling
parameters of each vCPU of a domain"

Or something like this.

> Changes on PATCH v2:
So, this kind of summary goes below the '---', as we don't want it in
the final history. And what it should contain what actually changed
between previous versions and this one, while this...

> 1) Change struct xen_domctl_scheduler_op, for transferring per-vcpu parameters
> between libxc and hypervisor.
> 2) Handler of XEN_DOMCTL_SCHEDOP_getinfo now just returns the default budget 
> and period values of RTDS scheduler.
> 3) Handler of XEN_DOMCTL_SCHEDOP_getvcpuinfo now can return a random subset 
> of the parameters of the VCPUs of a specific domain
... looks more like something that could actually be in the actual
changelog (so not under any 'Changes on PATCH v2' preamble), as it
dscribes how the hypercall interface looks like.

<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.