Re: [Xen-devel] [PATCH v3 for Xen 4.6 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Tue, 2015-07-07 at 10:33 -0500, Chong Li wrote:
> On Tue, Jul 7, 2015 at 3:59 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >
> > With this type gone I'm not even sure we need to wrap this in
> > another union; not doing so would eliminate some of the other
> > changes in this patch.
> 
> I see your point. Because of xen_domctl_schedparam_vcpu_t, we still
> need to define struct xen_domctl_sched_sedf/credit/credit2/rtds
> outside of struct xen_domctl_scheduler_op. Then the struct would be
> like:
> 
>  struct xen_domctl_scheduler_op {
>      uint32_t sched_id;  /* XEN_SCHEDULER_* */
>      uint32_t cmd;       /* XEN_DOMCTL_SCHEDOP_* */
>      union {
>         struct xen_domctl_sched_sedf sedf;
>         struct xen_domctl_sched_credit credit;
>         struct xen_domctl_sched_credit2 credit2;
>         struct xen_domctl_sched_rtds rtds;
>         struct {
>             XEN_GUEST_HANDLE_64(xen_domctl_schedparam_vcpu_t) vcpus;
>             uint16_t nr_vcpus;
>         } v;
>      } u;
>  };
>  typedef struct xen_domctl_scheduler_op xen_domctl_scheduler_op_t;
> 
> This design is good for compatibility. Dario, what do you think?
> 
I understood Jan's suggestion in the same exact way as you, as you can
see in my own email, and I like it.

Sorry for being a bit out-of-sync, I've been having internet issues
today (now things are working, but I'm not sure it'd be permanent! :-/).

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel