[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/4] x86/pvh: Handle hypercalls for 32b PVH guests

On 07/07/2015 05:20 AM, Jan Beulich wrote:
On 29.06.15 at 22:21, <boris.ostrovsky@xxxxxxxxxx> wrote:
@@ -4929,6 +4928,27 @@ static hvm_hypercall_t *const 
pvh_hypercall64_table[NR_hypercalls] = {
      [ __HYPERVISOR_arch_1 ] = (hvm_hypercall_t *)paging_domctl_continuation
+extern void compat_mmuext_op(void); /* XXX: need proper declaration */
No XXX like this please. Just add a suitable declaration. And in fact
adding it here (with correct arguments, and without the comment)
would seem quite fine to me.

The XXX here was meant for eliciting comments from reviewers ;-)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.