Re: [Xen-devel] [PATCH v6 16/16] x86/hvm: track large memory mapped accesses by buffer offset

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.07.15 at 18:25, <paul.durrant@xxxxxxxxxx> wrote:

(sorry for sending this in pieces - I started this reply and then another)

> --- a/xen/include/asm-x86/hvm/vcpu.h
> +++ b/xen/include/asm-x86/hvm/vcpu.h
> @@ -42,6 +42,17 @@ struct hvm_vcpu_asid {
>      uint32_t asid;
>  };
>  
> +/*
> + * We may read or write up to m256 as a number of device-model
> + * transactions.
> + */
> +struct hvm_mmio_cache {
> +    unsigned long size;
> +    uint8_t buffer[32];
> +    unsigned long gla;
> +    uint8_t dir;
> +};

"size" can be unsigned int (or even less, but that's not worth it) and
hence the structure size can be shrunk by putting it next to "dir".

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel