[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH OSSTEST v7 1/2] cr-publish-flight-logs: support publishing files from $HOME/public_html

On Thu, 2015-07-09 at 13:48 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v7 1/2] cr-publish-flight-logs: support 
> publishing files from $HOME/public_html"):
> > Any arguments given after the flight are assumed to be files or
> > directories relative to $HOME/public_html which should be published to
> > $c{Publish} at the same relative path.
> > 
> > Removing the requirement that a flight be provided, by accepting '',
> > allows this to be used even in contexts which have no flight.
> > 
> > The results subtree is always published if $c{ResultsPublish} is set,
> > since it doesn't depend on any particular flight.
> Uh.  Looking at this, I hadn't spotted that in your other patch you
> generate the output in ~/public_html.  Shouldn't it be in results/
> (which is nowadays a general place for publicly visible output) ?
> At the very least, if you do mean ~/public_html, you should be using
> WebspaceFile.

Results would be ok too, if you prefer (which you seem to so I shall
make that change).

> Also:
> > -sub copydir ($$) {
> > +sub copylogs ($$) {
> Why did you rename this function ?

I meant to mention this in the commit message and forgot, it was just
because the thing I was now copying wasn't a dir...

But if I generate the file into results this isn't need, the existing
publication of Results will do the job for free.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.