[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3] x86: correct socket_cpumask allocation

On 07/09/2015 11:16 AM, Andrew Cooper wrote:
On 09/07/15 15:23, Chao Peng wrote:
For booting cpu, the socket number is not needed to be 0 so
it needs to be computed by cpu number.

For secondary cpu, phys_proc_id is not valid in CPU_PREPARE
notifier(cpu_smpboot_alloc), so cpu_to_socket(cpu) can't be used.
Instead, pre-allocate secondary_cpu_mask in cpu_smpboot_alloc()
and later consume it in smp_store_cpu_info().

This patch also change socket_cpumask type from 'cpumask_var_t *'
to 'cpumask_t **' so that smaller NR_CPUS works.

Reported-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Tested-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Signed-off-by: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>
The v2 of this path seems to be holding up fine against the XenServer
test pool.  No failures to boot encountered so far.

Tested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

As the differences between v2 and v3 appear largely mechanical and not
functional in nature, this Tested-by can probably still stand.

Works for me as well. (You can add 'Tested-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>' although I think by now there are enough of those)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.