Re: [Xen-devel] [PATCH v2 25/27] tools/libxl: Handle checkpoint records in a libxl migration v2 stream

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 10/07/15 12:18, Ian Campbell wrote:
> On Thu, 2015-07-09 at 19:26 +0100, Andrew Cooper wrote:
>
>> @@ -3349,6 +3353,8 @@ struct libxl__stream_read_state {
>>      LIBXL_STAILQ_HEAD(, libxl__sr_record_buf) record_queue;
>>      enum {
>>          SRS_PHASE_NORMAL,
>> +        SRS_PHASE_BUFFERING,
>> +        SRS_PHASE_UNBUFFERING,
> I'd be inclined towards calling the latter DRAINING or PROCESSING or
> some such, perhaps tying into my comment about the separate recursion
> guard thing earlier on in the series.

I considered PROCESSING at first, but it a plausible description of what
is currently NORMAL, so I avoided it.

I have to admit that I don't particularly like UNBUFFERING either, but
it was the least-bad of a number of bad alternatives I came up with.

>
> But that's a bikeshedding issue on an internal thing so my only real
> comment is:
>
>> +    if (rc == 0)
>> +        ret = 0; /* Success */
>> +    else if (stream->phase == SRS_PHASE_BUFFERING)
>> +        ret = 2; /* Failover */
>> +    else
>> +        ret = 1; /* Error (fatal) */
> Maybe we should have had an enum or some #defines for these (this is
> really a comment on some previous patch).

Will do.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel