[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [v7][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

>>> On 10.07.15 at 15:26, <George.Dunlap@xxxxxxxxxxxxx> wrote:
> I also said that if we went with anything other than STRICT that we'd
> need to check to make sure that the domain really was the hardware
> domain before proceeding, in case the assumption that pdev->domain ==
> hardware_domain ever changed.  (Perhaps with an ASSERT -- Jan, what do
> you think?)

Yes, such an ASSERT() seems okay/desirable.

> Also, passing in RELAXED in locations where the flag is completely
> ignored (such as when removing mappings) doesn't really make any
> sense.
> On the whole I think it would be better if you removed the RELAXED
> flag for both removals and for hardware domains.

But what would he pass instead? Or wait - iirc I had even suggested
a way to do so by combining two arguments. Would need to go dig
that out, because I think the idea got dropped without good reason.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.