Re: [Xen-devel] [PATCH 1/1] libxl: set stub domain size based on VRAM size

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Eric Shelton writes ("[PATCH 1/1] libxl: set stub domain size based on VRAM 
size"):
> Allocate additional memory to the stub domain for qemu-traditional if
> more than 4 MB is assigned to the video adapter to avoid out of memory
> condition for QEMU.

>      dm_config->b_info.max_vcpus = 1;
>      dm_config->b_info.max_memkb = 32 * 1024;
> +    if (guest_config->b_info.video_memkb > 4096)
> +        dm_config->b_info.max_memkb += guest_config->b_info.video_memkb - 
> 4096;

Thanks for diagnosing this.  This seems a reasonable approach to me.
I have only one small stylistic comment: please use max() as found in
libxl_internal.h.

Eg,

      dm_config->b_info.max_memkb = 28 * 1024 +
           max(guest_config->b_info.video_memkb, 4096);

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel