Re: [Xen-devel] [v7][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

> > Do you mean I should merge them as one as possible?
> "Factor it out" means to break out into a separate function (or maybe
> a macro or something, but in this case a function is appropriate).  So
> in this case take the two sets of similar code, combine them into a
> function with appropriate arguments, and then call that function in
> both places.
>
> Finding multiple occurrences of very similar code is usually a sign
> that refactoring is needed.
Thanks for you explanation.

> > But seems not be possible because we have seveal combinations of these
> > two conditions, strategy = LIBXL_RDM_RESERVE_STRATEGY_HOST and one or
> > pci devices are also passes through.
[snip]

> > Sorry I can't figure out a good name here :) Any suggestions?
> The hypervisor seems to call this `pfn_to_paddr'.
Okay.


Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel