Re: [Xen-devel] [PATCH v4 06/17] xen/arm: ITS: Add virtual ITS driver

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sat, 2015-07-11 at 20:18 +0530, Vijay Kilari wrote:
> Hi Ian,
> 
> On Fri, Jul 10, 2015 at 7:24 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> > On Fri, 2015-07-10 at 13:12 +0530, vijay.kilari@xxxxxxxxx wrote:
> >> +/* RB-tree helpers for vits_device attached to a domain */
> >
> > In the rest of the series I found this used in three places:
> >       * On assignment, to insert the device into the tree
> >       * On deassignment, to remove it again
> >       * In vgic_vcpu_inject_lpi, where the device is looked up and then
> >         never used.
> >
> > I don't see any other use and therefore I don't think this RB tree
> > serves any purpose, which is consistent with the design which doesn't
> > require this lookup anywhere. Please remove it.
> >
> > If there is some use of it in some future series (e.g. perhaps the PCI
> > one) then please still remove it and add a patch to that series to
> > introduce it.
> >
> 
> You mean for now we will remove RB-tree for managing devices assigned
> to domain

Yes, it isn't needed for ITS at all AFAICT and having it around has just
tempted you into using it incorrectly during vpli injection.

>  and introduce RB-tree and do look up when pci-passthrough is
> introduced?.

If it is needed then yes.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel