[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 05/11] xen: grant_table: implement grant_table_warn_active_grants()

>>> On 13.07.15 at 11:08, <ian.campbell@xxxxxxxxxx> wrote:
> On Mon, 2015-07-13 at 09:45 +0100, Jan Beulich wrote:
>> >>> On 10.07.15 at 18:24, <konrad.wilk@xxxxxxxxxx> wrote:
>> > On Tue, Jun 23, 2015 at 06:11:47PM +0200, Vitaly Kuznetsov wrote:
>> >> Log first 10 active grants of a domain. This function is going to be used
>> >> for soft reset, active grants on this path usually mean misbehaving 
> backends
>> >> refusing to release their mappings on shutdown.
>> > 
>> > Is there an particular reason 10 was choosen instead of 42 for example :-)
>> > 
>> > Also the 10 should probably have an #define for it.
>> Or even be command line controllable.
> That sounds like overkill to me, what's wrong with some random hardcoded
> number for a simple debug aid like this?

From briefly looking at the code it seemed to be more than just a
debug aid (i.e. failing the operation if the count was exceeded). If
the number indeed only controls how many entries get printed,
then a #define certainly is fine.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.