Re: [Xen-devel] [PATCH v3 17/28] tools/libxl: Infrastructure for reading a libxl migration v2 stream

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [PATCH v3 17/28] tools/libxl: Infrastructure for 
reading a libxl migration v2 stream"):
> On 13/07/15 16:08, Ian Jackson wrote:
> > This means that the carefd functions bracketing open are easy to see
> > and there is no entanglement with error-handling flow control.
> 
> libxl__carefd_opened() doesn't tolerate being handed -1.  It cannot be
> used ahead of the error check.

Wait, what ?

(reads)

The doc comment says:

  /* Combines _record and _unlock in a single call.  If fd==-1,
   * still does the unlock, but returns 0.  Cannot fail. */
  _hidden libxl__carefd *libxl__carefd_opened(libxl_ctx *ctx, int fd);

but the implementation agrees with you.


Under the circumstances I am going to drop this request from this
review and treat this as a cleanup activity.

Sorry.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel