[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 16/17] xen/arm: ITS: Generate ITS node for Dom0

Hi Stefano,

On 13/07/2015 18:32, Stefano Stabellini wrote:

All these #ifdefs are a bit ugly. Couldn't we just build this code
always, even on arm32, relying on dt_match_node not to match in that

I'm not in favor of any ITS code in the common code unless it's strictly necessary.

In this specific case, the number of ITS between DOM0 and the hardware may be different. Per the design document, we only support 1 virtual ITS.

Furthermore, on the version 3 of this patch [1], I said that it's possible to do it in the hwdom_dt_callback and avoid all this mess in a function which only browse the device tree.


[1] http://lists.xen.org/archives/html/xen-devel/2015-07/msg01092.html

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.