[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 12/17] xen/arm: ITS: Initialize LPI irq descriptors and route

Hi Stefano,

On 13/07/2015 19:13, Stefano Stabellini wrote:
On Fri, 10 Jul 2015, vijay.kilari@xxxxxxxxx wrote:
From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

Allocate and initialize irq descriptor for LPIs and
route LPIs to guest

Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index a5f66f6..8190a46 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -30,6 +30,7 @@

  #include <asm/mmio.h>
  #include <asm/gic.h>
+#include <asm/gic-its.h>
  #include <asm/vgic.h>

  static inline struct vgic_irq_rank *vgic_get_rank(struct vcpu *v, int rank)
@@ -111,6 +112,15 @@ int domain_vgic_init(struct domain *d, unsigned int 
      for (i=0; i<d->arch.vgic.nr_spis; i++)
          vgic_init_pending_irq(&d->arch.vgic.pending_irqs[i], i + 32);

+#ifdef CONFIG_ARM_64
+    d->arch.vgic.pending_lpis = xzalloc_array(struct pending_irq, NR_GIC_LPI);

Would it be possible to only allocate pending_lpis if lpi_supported?

This should be called in the vITS code and not in the common vgic... Therefore no need to check if lpi are supported.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.