[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable new rdm policy parameters

On 2015/7/14 1:08, Ian Jackson wrote:
Ian Campbell writes ("Re: [Xen-devel] [v7][PATCH 16/16] tools: parse to enable new 
rdm policy parameters"):
On Mon, 2015-07-13 at 17:55 +0800, Chen, Tiejun wrote:
So I can do this as you're expecting now, but seems our change would
make the code style very inconsistent inside this function.

You're right, it would, but I think that is what is called for.

I think one could make an argument that the exception described in the
first section of tools/libxl/CODING_STYLE applies here for the
whitespace issues, but not for the long lines I think.

The wording of the exception is that:

   If it is not feasible to conform fully to the style while patching old
   code, without doing substantial style reengineering first, we may
   accept patches which contain nonconformant elements, provided that
   they don't make the coding style problem worse overall.

   In this case, the new code should conform to the prevailing style in
   the area being touched.

In this case it is indeed feasible to conform fully to the new
whitespace style for these added lines.  It leaves the code in this
function in a mixture of styles, but that is not "infeasible".  It is

Okay. I'll follow the new code style.


merely undesriable, but so is adding more code in the wrong style.

The sentence about new code conforming to the prevailing style applies
only "in this case", ie, only if "it is not feasible ... to conform to
the new style".


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.