[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 04/17] xen/arm: ITS: Add helper functions to manage its_devices

On 15/07/2015 16:21, Vijay Kilari wrote:
A general question, how do you ensure any concurrent insert to the RB-tree?
Is it taken care by the ITS lock and the caller?

I would be ok to defer the locking for when the PCI passthrough is supported
as all the ITS device are added when Xen is booted.

A TODO would be worth to add. With the TODO and the answer to my questions:

I have added new lock "rb_its_dev_lock" in patch #8 where caller is managing.

It's rather strange to introduce the lock later given that anyone can call these functions (they are exported).

You need to ensure that the caller does take the lock by adding an ASSERT(spin_is_locked(...)) in each function.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.