Re: [Xen-devel] [v7][PATCH 00/16] Fix RMRR

[Lars Kurth <lars.kurth.xen@xxxxxxxxx>]

> On 16 Jul 2015, at 09:30, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> On Thu, 2015-07-16 at 09:08 +0100, Jan Beulich wrote:
>> 
>>> 
>>> Does this imply this is already reviewed?
>> 
>> No, that would be expressed by Reviewed-by. Acked-by merely
>> means no objection by the maintainer for the change to go in.
> 
> For my part I, perhaps wrongly, use Acked-by for both. If I haven't
> actually carefully reviewed the change I will usually say so, e.g. "I
> see XXX has reviewed this already, so that's fine by me" or something
> similar (which I admit gets lost once it becomes just the tags).
> 
> I can't speak for Ian or Wei (now CCd) but Ian at least I think operates
> similarly.
> 
> Ian.

We shouldn't have an argument about this now. I wrote some scripts yesterday to 
track Acked-by and Reviewed-by and it is clear that these two tags are not 
consistently used at the moment. Maybe something to pick up in 2 weeks

Regards
Lars



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel