[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 12/25] tools/libxl: introduce enum type libxl_checkpointed_stream

On 07/16/2015 06:34 PM, Ian Campbell wrote:
On Wed, 2015-07-15 at 21:58 +0800, Yang Hongyang wrote:

On 07/15/2015 08:34 PM, Ian Campbell wrote:
On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote:
introduce enum type libxl_checkpointed_stream in IDL.
rename the last argument of migrate_receive from "remus" to
"checkpointed" since the semantics of this parameter has

   libxl_domain_restore_params isn't changed here,
   checkpointed_stream is still an int.
   It has to change eventually and other callers will have to be
   updated to cope (and there should be LIBXL_HAVE_...).

Will this be fixed up later in this series? If so please say so.

It's not fixed in this series, I plan to fix this later, but seems there
will be another round for this series, I can fix this in the next version.
My main concern is that this change is an api change, it will affect the
existing callers.

It is already an API change, whether or not is reflected in the type of
checkpointed_stream in the API struct you've already changed the
semantics of that field and so a LIBLX_HAVE is already needed, it makes
no sense to not also change the type to be correct while you are making
these changes even if the interchangeability of ints and enums seems on
the face of it to make it possible to avoid doing so.

Fair enough, will fix, thank you!




Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.