Re: [Xen-devel] [PATCH XEN v2 08/15] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-16 at 10:48 -0400, Jason Andryuk wrote:
> Ian,
> 
> I'm not subscribed to xen-devel and read your patch from the gmane.org
> web interface.

No problem, I'm recopying the list for you now.

> > After this change libxenvchan no longer needs to link against
> > libxenctrl. It still needs xenctrl.h in one file for xen_mb and
> > friends.
> 
> @@ -109,7 +119,7 @@ LDLIBS_libxenstat  = $(SHDEPS_libxenstat) 
> $(XEN_LIBXENSTAT)/libxenstat$(libexten
>  SHLIB_libxenstat   = $(SHDEPS_libxenstat) -Wl,-rpath-link=$(XEN_LIBXENSTAT)
>  
>  CFLAGS_libxenvchan = -I$(XEN_LIBVCHAN)
> -SHDEPS_libxenvchan = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) 
> $(SHLIB_libxenevtchn)
> +SHDEPS_libxenvchan = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) 
> $(SHLIB_libxenevtchn) $(SHLIB_libxengnttab) $(SHLIB_libxengntshr)
>  LDLIBS_libxenvchan = $(SHDEPS_libxenvchan) 
> $(XEN_LIBVCHAN)/libxenvchan$(libextension)
>  SHLIB_libxenvchan  = $(SHDEPS_libxenvchan) -Wl,-rpath-link=$(XEN_LIBVCHAN)
>  
> I see in tools/libvchan/Makefile you removed $(LDLIBS_libxenctrl), but
> did you want to remove $(SHLIB_libxenctrl) here?

I think I did, yes, thanks.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel