[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 02/20] xen: Introduce a function to split a Linux page into Xen page

On 16/07/15 17:09, Julien Grall wrote:
> Hi Andrew,
> On 16/07/2015 16:19, Andrew Cooper wrote:
>>> Hmmm... right. I'm not sure why the compiler didn't catch it.
>> Because there is not a path where it can possibly be used
>> uninitialised.  The for() loop is guaranteed to execute at least once.
> Oh right, the ret = 0 asked by Stefano confused me. In this case, I
> don't see the point to initialize ret to 0 as it will never happen to
> have the Linux page granularity inferior to the Xen page granularity.

I agree.  I would certainly not initialise ret if that was my code.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.