Re: [Xen-devel] [Patch RFC 1/4] usb: support device specification via <bus>-<port>

[Gerd Hoffmann <kraxel@xxxxxxxxxx>]

On Do, 2015-07-16 at 17:47 +0200, Juergen Gross wrote:
> Today a host usb device can be specified either via <vendor>:<product>
> or via <bus>.<device> syntax. Add the possibility to specify it via
> <bus>-<port> as this is needed for the support of xen pvusb backend.

-device usb-host,hostbus=<bus>,hostport=<port> should already do what
you want.

> diff --git a/hw/usb/host-legacy.c b/hw/usb/host-legacy.c
> index 3cc9c42..526108c 100644
> --- a/hw/usb/host-legacy.c
> +++ b/hw/usb/host-legacy.c

I don't think we should extend this.  This exists purely for backward
compatibility reasons.

> +out:
>      qdev_prop_set_uint32(&dev->qdev, "hostbus",   filter.bus_num);
>      qdev_prop_set_uint32(&dev->qdev, "hostaddr",  filter.addr);
> +    if (filter.port) {
> +        qdev_prop_set_string(&dev->qdev, "port",  filter.port);

Hmm?  This should have been "hostport", right?

cheers,
  Gerd



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel