[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 2/3] libxl: localtime(3) can return NULL

On Fri, Jul 17, 2015 at 06:05:45PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH v4 2/3] libxl: localtime(3) can return NULL"):
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >          tm = localtime(&t);
> > +        if (!tm) {
> > +            LOG(ERROR, "Failed to call localtime");
> localtime sets errno if it fails.  So you mean LOGE.

Heh. Linux manpage doesn't say so. But


does say that.

I will rework this patch and send it out next week with other coverity
scan inspired patches I accumulate.

> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.