Re: [Xen-devel] [PATCH v4 08/17] xen/arm: ITS: Add APIs to add and assign device

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

Hi Julien

On Wed, Jul 15, 2015 at 7:45 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hi Vijay,
>
>
> On 10/07/2015 09:42, vijay.kilari@xxxxxxxxx wrote:
>>
[...]
>> +int its_assign_device(struct domain *d, u32 vdevid, u32 pdevid)
>
>
> [...]
>
>> +    for ( i = 0; i < pdev->nr_lpis; i++ )
>> +    {
>> +        plpi = its_get_plpi(pdev, i);
>> +        route_irq_to_guest(d, i, plpi, "LPI");
>> +        desc = irq_to_desc(plpi);
>> +        spin_lock(&desc->lock);
>> +        set_irq_device(desc, pdev);
>
>
> This should be part of its_add_device and not its_assign_device.

   The domain to which irq should be routed is known only in assign_device.
So route_irq_to_guest is called from assign_device.

I can move set_irq_device to add_device

Regards
Vijay

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel