Re: [Xen-devel] [v9][PATCH 07/16] hvmloader/e820: construct guest e820 table

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

> > > > Before you add memory_map.nr_map, you should be able to iterate
> > > > from 0 to (not inclusive) nr. At least as far as I recall the original
> > > > patch.
> > > Sorry, I really don't understand what you want.
> > >
> > > Before we add memory_map.nr_map, e820[0, nr) don't include low/high
> > > memory, right?
> > Why? memory_map is representing the reserved areas only, isn't it?
> > If that's not the case, then of course everything is fine.
> I'm pretty sure the memory map we get here is an extension of the
> original PV-only get_e820 hypercall, which *does* include both the
> lowmem and highmem regions.
>
> In any case, it's pretty clear from the patched code that Tiejun is
> removing the old code which created the lowmem and highmem regions and
> is not replacing it.  Where do you think the highmem region he's
> looking for was coming from?
On second thoughts, I prefer to check/sync memory_map.map[] before copy 
them into e820 since ultimately this can make sure hvm_info, 
memory_map.map[] and e820 are on the same page.
Anyway, I would send out v10 to address others so please further post 
your comments over there.
Thanks
Tiejun


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel