Re: [Xen-devel] [PATCH 2/5] xl: Command line: Remove maximum argument limit for network-attach

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 17, 2015 at 06:00:48PM +0100, Ian Jackson wrote:
> This limit of 11 has been in this function since it was written, but
> serves no purpose.  The extra arguments are fed one by one to
> parse_nic_config, and it is possible to have as many as you like.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  tools/libxl/xl_cmdimpl.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 55c041c..770b71c 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -6373,11 +6373,6 @@ int main_networkattach(int argc, char **argv)
>          /* No options */
>      }
>  
> -    if (argc-optind > 11) {
> -        help("network-attach");
> -        return 0;
> -    }
> -
>      domid = find_domain(argv[optind]);
>  
>      config= xlu_cfg_init(stderr, "command line");
> -- 
> 1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel