Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jul 20, 2015 at 11:16:34AM +0200, Olaf Hering wrote:
> On Mon, Jul 20, Jan Beulich wrote:
> 
> > >>> On 19.07.15 at 11:33, <olaf@xxxxxxxxx> wrote:
> > > [  198s] block-log.c:549:23: error: array subscript is above array bounds 
> > > [-Werror=array-bounds]
> > > [  198s]      if (s->connections[i].id == id)
> > > [  198s]                        ^
> > 
> > So what makes the compiler right with that complaint? I.e. how does
> > it know i > 0 here? After all - afaict - s->connected can only be 0 or
> 
> It has to assume that ->connected can get any value because the input
> comes from outside the unit.
> 
> To reduce the patch size "&& i < MAX_CONNECTIONS" could be added.
> 

A smaller patch would be preferable at this stage.

Wei.

> Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel