Re: [Xen-devel] [v10][PATCH 07/16] hvmloader/e820: construct guest e820 table

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.07.15 at 08:16, <tiejun.chen@xxxxxxxxx> wrote:
> +        /* If there was no highmem region, just create one. */
> +        if ( i == memory_map.nr_map )
> +        {
> +            memory_map.map[i].addr = ((uint64_t)1 << 32);
> +            memory_map.map[i].size = add_high_mem;
> +            memory_map.map[i].type = E820_RAM;

Don't you need to increment memory_map.nr_map here?

> +        }
> +
> +        /* A sanity check if high memory is broken. */
> +        BUG_ON( high_mem_end !=
> +                memory_map.map[i].addr + memory_map.map[i].size);
> +    }
> +
> +    /* Now fulfill e820. */

s/fulfill/fill/.

> +    /* Finally we need to sort all e820 entries. */
> +    for ( j = 0; j < nr-1; j++ )
> +    {
> +        for ( i = j+1; i < nr; i++ )

Blanks around binary operators please.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel