Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH for-4.6 2/3] libxl/psr: use Xen error codes 
when checking hypercall return values"):
> We cannot use the systems errno values when checking return values from Xen,
> because some OSes don't have the same set of errno definitions. Instead
> use the definitions present in Xen public errno.h header.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> I have not checked if there are other places in libxl that need similar
> treatment, I just came around this because FreeBSD doesn't have EBADSLT
> defined.

Right.  There is probably more of this, but that's not a blocker for
this patch.

Maybe it would be worth mentioning this issue in CODING_STYLE.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel