Re: [Xen-devel] [PATCH v2] xl: fix vcpus to vnode assignement in config file

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Tue, 2015-07-21 at 15:13 +0100, Ian Campbell wrote:
> On Mon, 2015-07-20 at 11:30 +0200, Dario Faggioli wrote:
> > In fact, right now, if the "vcpus=" list (where the
> > user specifies what vcpus should be part of a vnode)
> > has multiple elements, things don't work.
> > E.g., the following examples all result in failure
> > to create the guest:
> 
> What is the failure?
> 
With the following configuration:
vcpus       = '4'
memory      = '1024'
vnuma = [ [ "pnode=0","size=512","vcpus=0,1","vdistances=10,20"  ],
          [ "pnode=1","size=512","vcpus=2,3","vdistances=20,10"  ] ]

The error message is this one:
xl: maxvcpus < vcpus

The reason is that, without this change, we only process the first
element of the "vcpus=" list, i.e., only vcpu 0 (for vnode 0) and vcpu 2
(for vnode 1), up to a total of 2 (rather than 4) vcpus.

Basically, things only work if for each vnode, its vcpus are specified
by means of a single element.

> > Reason is we need either a multidimentional array,
> > or a bitmap, to temporary store the vcpus of a
> > vnode, while parsing the vnuma config entry.
> 
> That sounds like a cure, not the reason for the failure. Please can you
> explain the nature of the failure, so it becomes clear why this change
> is needed.
> 
Ok, I'll mention this in here.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel