[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

Chen, Tiejun writes ("Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect 
and avoid conflicts with RDM"):
> > I then go through the comments one by one and either:
> >
> >        * make the _complete_ code change, including adding the "Changes
> >          in vN" bit to the commit log and delete that comment from the
> >          reply
> Are you saying this case of resending this particular patch online?

Here is an example of what Ian C is talking about: You failed to
address all my comments before posting v10.  That caused me to post

  This is now the third time I have posted that text.  It is the fifth
  request or clarification I have had to make about this very small
  area.  I have to say that I'm finding this rather frustrating.

You should have been systematic.  Like Ian C suggests.  I do it that
way too.  Instead, you repeatedly left things undone.

> Yes, in this case we're arguing, I was really trying to send a sample of 
> this code fragment to ask this before I sent out the complete change.

No, your v10 series was not a "sample".

It is of course OK to post a sample.  But a reviewer will not read
such a sample thoroughly; they will not look for all problems.  The
reviewer will look at the sample, so that the reviewer can understand
your words.  They will consider the aspects of the sample that are
being discussed.  They will not consider other aspects of the sample.

You did post such a sample in <55AE2BB1.9030604@xxxxxxxxx>.  I read
the sample, to understand what your words meant.

Then later, you complained that:

  But indeed, before I post this whole patch online I also picked up
  this chunk of code to ask you to take a look that.

Ie you complained that I did not thoroughly review your "sample".

You cannot have this both ways.  When you are posting a "sample", it
is purely to illuminate the particular discussion.  When you are
posting a full patch for review, you must have addressed _every_
previous comment.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.