[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 for-4.6 2/3] xen: replace non-POSIX error codes

>>> On 22.07.15 at 13:07, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/common/hvm/save.c
> +++ b/xen/common/hvm/save.c
> @@ -114,7 +114,7 @@ int hvm_save_one(struct domain *d, uint16_t typecode, 
> uint16_t instance,
>          uint32_t off;
>          const struct hvm_save_descriptor *desc;
> -        rv = -EBADSLT;
> +        rv = -EDOM;
>          for ( off = 0; off < (ctxt.cur - sizeof(*desc)); off += desc->length 
> )
>          {
>              desc = (void *)(ctxt.data + off);

In what sense do you view EDOM applicable here? It looks pretty
strange to me (also the one further up, but as George says the
precise value there doesn't really matter all that much). ENXIO or
ENOENT would seem more suitable here (and for the one above I'd
rather pick e.g. EACCES, EOPNOTSUPP, or even ENOSYS). I'd be
fine adjusting these on commit, i.e. no need to re-submit (but
please let me know if you have a preference for any of the

In any event, consider the whole series
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
(or the other two, and with the changes made also this one,
even Reviewed-by).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.