Re: [Xen-devel] [v11][PATCH 16/16] tools: parse to enable new rdm policy parameters

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jul 22, 2015 at 03:09:55PM +0100, Ian Jackson wrote:
> Tiejun Chen writes ("[v11][PATCH 16/16] tools: parse to enable new rdm policy 
> parameters"):
> > This patch parses to enable user configurable parameters to specify
> > RDM resource and according policies which are defined previously,
> > 
> > Global RDM parameter:
> >     rdm = "strategy=host,policy=strict/relaxed"
> > Per-device RDM parameter:
> >     pci = [ 'sbdf, rdm_policy=strict/relaxed' ]
> > 
> > Default per-device RDM policy is same as default global RDM policy as being
> > 'relaxed'. And the per-device policy would override the global policy like
> > others.
> > 
> > CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Wei, as you know, I am double-checking the acks on this series.
> 
> You acked v4.  But v11 is somewhat different.  Your ack was retained
> and my subject line search did not turn up any authority for that.
> 
> The v* message by the submitter says:
> 
> > v8:
> > 
> > * Clean some codes style issues.
> > 
> > v7:
> > 
> > * Just sync with the fallout of renaming parameters from patch #10.
> > 
> > v6:
> > 
> > * Just sync those renames introduced by patch #10.
> > 
> > v5:
> > 
> > * Need a rebase after we make all rdm variables specific to .hvm.
> > * Like other pci option, the per-device policy always follows
> >   the global policy by default.
> 
> v4 does not apply in the context of the current series.
> 
> Below is the interdiff between v4 and v11, generated with `diff -b'.
> (Sorry for handing you an interdiff.)
> 
> Please ack/nack.
> 
> Thanks,
> Ian.
> (wearing committer hat)

Apart from the renaming and minor style fixes. The most notable hunk is

>               pcidev->seize = pci_seize;
> -+            /* We'd like to force reserve rdm specific to a device by 
> default.*/
> -+            pcidev->rdm_reserve = LIBXL_RDM_RESERVE_FLAG_STRICT;
> -             if (!xlu_pci_parse_bdf(config, pcidev, buf))
> -                 d_config->num_pcidevs++;
> -         }
> ++            /*
> ++             * Like other pci option, the per-device policy always follows
> ++             * the global policy by default.
> ++             */
> ++            pcidev->rdm_policy = b_info->u.hvm.rdm.policy;
> +             e = xlu_pci_parse_bdf(config, pcidev, buf);
> +             if (e) {
> +                 fprintf(stderr,

The default behaviour is changed but it's indeed mentioned in v5 change
log and in line with what Jan and George suggested.

So:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

on v11

>  -- 
> -1.9.1
> -
> +1.7.10.4
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel