Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

El 10/07/15 a les 20.47, Konrad Rzeszutek Wilk ha escrit:
> On Fri, Jul 03, 2015 at 01:34:45PM +0200, Roger Pau Monne wrote:
>> Add checks for ignored vcpu fields in HVM mode. HVM vCPUs (BSP and APs) are
>> always started in 32bit protected mode with paging disabled.
> 
> This is kind of odd in the placement of the series. The next couple of
> patches deal with the restructure of the HVM guests and the previous
> ones were too.

This patch is placed here because the next patch in this series makes
use of it (see the vcpu_hvm function in "libxc: introduce a xc_dom_arch
for hvm-3.0-x86_32 guests").

> And it is quite salient on the PVH/HVMLite protocol. I would think
> you would want to also update the documentation/misc/pvh as part
> of this patch. Perhaps move this further out in the patch series?

Yes, documentation needs to be updated. I was waiting to have the full
boot protocol nailed down before doing so.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel