Re: [Xen-devel] [PATCH v7 05/15] x86/altp2m: basic data structures and support routines.

["Sahita, Ravi" <ravi.sahita@xxxxxxxxx>]

>From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>Sent: Thursday, July 23, 2015 7:54 AM
>
>>>> On 23.07.15 at 16:36, <ravi.sahita@xxxxxxxxx> wrote:
>>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>>>Sent: Thursday, July 23, 2015 2:22 AM
>>>>>> On 23.07.15 at 01:01, <edmund.h.white@xxxxxxxxx> wrote:
>>>> +out:
>>>
>>
>> Missed sorry.
>>
>>
>>>Just to repeat - labels should be indented by at least one space.
>
>But you realize this isn't the only case, and it looked like you adjusted only
>exactly the one place where the comment was made?
>

I agree these kinds of things are hard to catch - we did go in and scan our v7 
for comment styles, indentation, case indentation, spaces in if conditional 
expressions etc,
But of course we missed some and this could be addressed - Andrew was also 
suggesting some sort of tool to do this would be good to use.

thanks
Ravi

>Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel