Re: [Xen-devel] [PATCH v9 08/11] xen: arch-specific hooks for domain_soft_reset()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.07.15 at 14:41, <vkuznets@xxxxxxxxxx> wrote:
> "Jan Beulich" <JBeulich@xxxxxxxx> writes:
> 
>>>>> On 16.07.15 at 18:27, <vkuznets@xxxxxxxxxx> wrote:
>>> --- a/xen/arch/x86/domain.c
>>> +++ b/xen/arch/x86/domain.c
>>> @@ -704,6 +704,90 @@ void arch_domain_unpause(struct domain *d)
>>>          viridian_time_ref_count_thaw(d);
>>>  }
>>>  
>>> +int arch_domain_soft_reset(struct domain *d)
>>> +{
>>> +    struct page_info *page = virt_to_page(d->shared_info), *new_page;
>>> +    int ret = 0;
>>> +    struct domain *owner;
>>> +    unsigned long mfn, mfn_new, gfn;
>>> +    p2m_type_t p2mt;
>>> +    unsigned int i;
>>> +
>>> +    /* Soft reset is supported for HVM domains only. */
>>> +    if ( !is_hvm_domain(d) )
>>> +        return -EINVAL;
>>
>> This suggests that the whole function may better go somewhere in
>> hvm/.
>>
>> And is this intentionally excluding PVH?
>>
> 
> Not really.
> 
> As far as I understand the descision is to go for "HVM without dm" way
> for PVH in future? In that case, isn't is_hvm_domain() supposed to
> return true for it?

We'd have to see how these is_...() functions end up getting
structured. For now, to cover both HVM and PVH we have
has_hvm_container_...().

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel