Re: [Xen-devel] [PATCH OSSTEST] standalone: Extend -h to support ident=host style specifications

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-07-24 at 14:42 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] standalone: Extend -h to support 
> ident=host style specifications"):
> > Allowing for multi-host tests.
> ...
> >     job=$1; shift
> > -   ./cs-adjust-flight -v $flight runvar-del $job host
> > +   ./cs-adjust-flight -v $flight runvar-del $job '/host$'
> 
> This regexp is slightly wrong because host runvars are all
>   (?:\w+_)?host$

I'll update.

> > +       hosts="$ident=$h $hosts"
> 
> Any reason you push it on the front rather than adding it to the end ?

So that it matches the order of the arguments. Which matters for the run
-test case. At least it did for ts-guest-nbd-mirror which wants to be given
$srvhost $clthost in that order.

> It _shouldn't_ matter, but what if someone specifies -h foo=X -h foo=Y ?

For run-test ts-* will get foo=X foo=Y on the command line. For run-job
OSSTEST_HOST_FOO=X will prevail.

Perhaps export_hosts_environ should process the list in $hosts in reverse?
I think that gets best of both worlds?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel