Re: [Xen-devel] [PATCH v5 01/22] xen/arm: Return success if dt node does not have irq mapping

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-07-28 at 14:13 +0100, Julien Grall wrote:
> Hi Vijay,
> 
> I think the title is too wide for the patch. I would rename to
> "xen/dt: Handle correctly node with interrupt-map in dt_for_each_irq_map"
> 
> On 27/07/15 12:11, vijay.kilari@xxxxxxxxx wrote:
> > From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> > 
> > dt_for_each_irq_map() returns error if no irq mapping is found.
> > With this patch, Ignore error and return success
> > 
> > Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> I think this would be a bug fix for Xen 4.6. Can you send it separately?

I'm happy to be pointed at subsets of a series which are suitable to go in
now, no particular need to resend separately, assuming it can be applied in
isolation.

> 
> > ---
> >  xen/common/device_tree.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> > index 323c3be..1325ad5 100644
> > --- a/xen/common/device_tree.c
> > +++ b/xen/common/device_tree.c
> > @@ -1085,7 +1085,7 @@ int dt_for_each_irq_map(const struct 
> > dt_device_node *dev,
> >      if ( imap == NULL )
> >      {
> >          dt_dprintk(" -> no map, ignoring\n");
> > -        goto fail;
> > +        return 0;
> >      }
> 
> At the same time, can you also fix the comment above the if (i.e "/* No
> interrupt map, check for an interrupt parent */") which is wrong?
> 
> >      imaplen /= sizeof(u32);
> >  
> > 
> 
> Regards,
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel