Re: [Xen-devel] [PATCH for 4.6] x86/hvm.c: fix regression in guest destruction

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-29 at 17:44 +0100, Andrew Cooper wrote:
> On 29/07/15 17:39, Ravi Sahita wrote:
> > As reported by Wei Lu on July 27 2015
> 
> Reported-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Which leaves an effectively empty commit message:

    x86/hvm.c: fix regression in guest destruction

    Reported-by: Wei Liu <    wei.liu2@xxxxxxxxxx    >
    Signed-off-by: Ravi Sahita <    ravi.sahita@xxxxxxxxx    >
    Reviewed-by: Andrew Cooper <    andrew.cooper3@xxxxxxxxxx    >
    Tested-by: Wei Liu <    wei.liu2@xxxxxxxxxx    >

If I were maintainer of this code I'd be very grumpy about the lack of a
commit log (What regression? What is the fix? Why is it correct?) for this
patch. I asked on IRC and Andy suggested instead:

    x86/hvm.c: Don't tear down altp2m state if it was never set up

which I have applied with. I still don't think the commit message is very
satisfactory, but I'm not maintainer of any of this code so meh.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel