Re: [Xen-devel] [PATCH for-4.6] xl/libxl: disable PV vNUMA

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 30, 2015 at 05:30:58PM +0200, Roger Pau Monné wrote:
> El 30/07/15 a les 17.12, Wei Liu ha escrit:
> > Update xl manual and disable PV vNUMA in libxl.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > ---
> >  docs/man/xl.cfg.pod.5      | 4 ++++
> >  tools/libxl/libxl_create.c | 9 +++++++++
> >  2 files changed, 13 insertions(+)
> > 
> > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> > index c78c3ba..782106c 100644
> > --- a/docs/man/xl.cfg.pod.5
> > +++ b/docs/man/xl.cfg.pod.5
> > @@ -261,6 +261,10 @@ Specify virtual NUMA configuration with positional 
> > arguments. The
> >  nth B<VNODE_SPEC> in the list specifies the configuration of nth
> >  virtual node.
> >  
> > +Note that virtual NUMA for PV guest is not yet supported, because
> > +there is issue with regard to cpuid handling that affects PV virtual
>            ^ an   ^regarding

Added "an", but "with regard to" is a commonly used phrase.

Did I miss anything?

Wei.

> > +NUMA.
> > +
> >  Each B<VNODE_SPEC> is a list, which has a form of
> >  "[VNODE_CONFIG_OPTION,VNODE_CONFIG_OPTION, ... ]"  (without quotes).
> >  
> > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> > index 4f2f50b..4f4273d 100644
> > --- a/tools/libxl/libxl_create.c
> > +++ b/tools/libxl/libxl_create.c
> > @@ -860,6 +860,15 @@ static void initiate_domain_create(libxl__egc *egc,
> >          goto error_out;
> >      }
> >  
> > +    /* PV vNUMA is not yet supported because there is issue with
> > +     * regard to cpuid handling.
> 
> Same.
> 
> > +     */
> > +    if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
> > +        d_config->b_info.num_vnuma_nodes) {
> > +        LOG(ERROR, "PV vNUMA not yet supported");
> > +        goto error_out;
> > +    }
> > +
> >      ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info);
> >      if (ret) {
> >          LOG(ERROR, "Unable to set domain create info defaults");
> > 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel