Re: [Xen-devel] [PATCH for-4.6 6/8] tools/libxl: Prepare to write multiple records with EMULATOR headers

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 29/07/15 12:54, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH for-4.6 6/8] tools/libxl: Prepare to write 
> multiple records with EMULATOR headers"):
>> With the newly specified EMULATOR_XENSTORE_DATA record, there are two
>> libxl records with an emulator subheader.  Refactor the existing code to
>> make future additions easier.
> ...
>> @@ -164,6 +198,7 @@ void libxl__stream_write_init(libxl__stream_write_state 
>> *stream)
>>      FILLZERO(stream->emu_dc);
>>      stream->emu_carefd = NULL;
>>      FILLZERO(stream->emu_rec_hdr);
>> +    FILLZERO(stream->emu_sub_hdr);
> This this just cautionary ?

Yes - the _init() function here initialises all private data.  Most of
it is probably not strictly necessary.

>
>> +    if (dss->type == LIBXL_DOMAIN_TYPE_HVM) {
>> +        switch(libxl__device_model_version_running(gc, dss->domid)) {
> I know you are just moving this code, but: space needed after
> `switch'.

So I do.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel