Re: [Xen-devel] [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-30 at 17:11 +0100, Wei Liu wrote:
> Update xl manual and disable PV vNUMA in libxl.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

and applied.

>  
> +    /* PV vNUMA is not yet supported because there is an issue with
> +     * cpuid handling.
> +     */

Personally I think this is wrong and should be
    /*
     * PV vNUMA...

but a) there are a bunch of similarly formatted comments in this function
and b) tools/libxl/CODING_STYLE doesn't actually cover comment style.

So I left it.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel