Re: [Xen-devel] [osstest test] 60149: regressions - FAIL

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 31, 2015 at 10:47:22AM +0100, Ian Campbell wrote:
> On Fri, 2015-07-31 at 07:40 +0100, Ian Campbell wrote:
> > 
> > >  test-amd64-i386-qemut-rhel6hvm-amd  9 redhat-install      fail REGR.
> > > vs. 60083
> > 
> > 2015-07-30 23:02:32 Z execution took 71 seconds[<=2x600]: timeout 630 ssh 
> > -o StrictHostKeyChecking=no -o BatchMode=yes -o ConnectTimeout=100 -o 
> > ServerAliveInterval=100 -o PasswordAuthentication=no -o 
> > ChallengeResponseAuthentication=no -o 
> > UserKnownHostsFile=tmp/t.known_hosts_60149.test-amd64-i386-qemuu-rhel6hvm
> > -amd root@xxxxxxxxxxxxx         mkdir -p /root/60149.test-amd64-i386
> > -qemuu-rhel6hvm-amd.redhat-newiso
> >         genisoimage -R -J -T -b isolinux/isolinux.bin -c 
> > isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -o 
> > /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.rhel-server-6.1-i386
> > -dvd.iso /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.redhat-newiso/.
> > Use of uninitialized value in pattern match (m//) at 
> > Osstest/TestSupport.pm line 1736.
> 
> By inspection I think this one might be:
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index a6d42bd..ceb4d0f 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -1733,7 +1733,7 @@ sub more_prepareguest_hvm ($$$$;@) {
>      }
>      my $disks = join ",\t\t\n", map { "'$_'" } @disks;
>  
> -    my $kernel = $ho->{Toolstack}->{Name} =~ m/xend/ ?
> +    my $kernel = toolstack($ho)->{Name} =~ m/xend/ ?
>       "kernel      = 'hvmloader'" : '';
>  
>      my $cfg = <<END;
> 
> Since toolstack() is the function which initialises $ho->{Toolstack} my
> hypothesis is that on this path nothing has previously called toolstack(),
> something which could well have changed over a rebase at some point. I
> could imagine also that ts-{redhat,debian-hvm,windows}-install might differ
> in some subtle way here.
> 

Good catch.

The root cause is ts-debian-hvm-install calls host_get_free_memory which
initialises toolstack in the background. It's a trick only used by
debian hvm test case.

And I think your fix is correct.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel