[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH OSSTEST v2 5/5] ms-flights-summary: Produce an HTML report of all active flights

Ian Campbell writes ("Re: [PATCH OSSTEST v2 5/5] ms-flights-summary: Produce an 
HTML report of all active flights"):
> On Fri, 2015-07-31 at 16:50 +0100, Ian Jackson wrote:
> > I think it's pretty good actually.  I have some minor stylistic
> > comments.  I haven't inspected the output, but as you say we can
> > improve it later.
> Thanks, I actually posted a v3 shortly after which rewrote a lot of this.

Oh, sorry.

> I'll try and apply those of your comments which are relevant to the v3
> though.

Fair enough.

> > > +     # Can we find a Job here?
> > >              Task => $arow->{owntaskid},
> > >       Info => $info,
> > 
> > I don't understand this comment.
> This didn't really belong in this patch. It was in relation to this
> paragraph from patch #1's commit message:
>     cmd_reset does not include a ->Job for jobs which are "(preparing)",
>     corresponding to a job which is going to use a shared host which is
>     currently being installed by another job. I was unable to figure out a
>     way to include these.
> The upshot is that N-1 of the N jobs which are going to share a host sit in
> the "Anonymous Jobs" list until the first job has finished with the actual
> installation of the host, instead of being associated with the proper job.
> I wasn't able to figure out how to get the original Job to include in those
> records in the allocations.

Yes.  I think this will do for now.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.